Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Virtual Piano Game #4880

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Added Virtual Piano Game #4880

merged 1 commit into from
Jul 18, 2024

Conversation

somilyadav7
Copy link
Contributor

PR Description 📜

An interactive virtual piano game built with HTML, CSS, and JavaScript. The objective of the game is to play musical notes by pressing the keys on the virtual piano, which correspond to real piano keys.
Fixes #4874


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-07-17 183649



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 17, 2024

Thank you @somilyadav7 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@somilyadav7
Copy link
Contributor Author

/assign

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 17, 2024
@somilyadav7
Copy link
Contributor Author

@ishita-43 why level 2?

@ishita-43
Copy link
Collaborator

@ishita-43 why level 2?

we had other games with same functionality thats why we added this game as an enhancement in the project

@kunjgit kunjgit merged commit 236f53a into kunjgit:main Jul 18, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 18, 2024

Thank you @somilyadav7 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Virtual Piano
3 participants